Avoid dirtying the worktree #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patching the pyproject.toml file like before led to a dirty worktree, which caused setuptools-scm to always generate dev versions even when making wheels for a tag. This commit refactors the CI so that patching the pyproject.toml file is no longer necessary. The (yet) private dependency project will be install directly from the Github repository as additional step before installing the rest of the test dependencies, and the Gitlab pipelines don't need to do anything special because they pull from an internal repository which hosts the dependency package.
Wuestengecko
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching the pyproject.toml file like before led to a dirty worktree, which caused setuptools-scm to always generate dev versions even when making wheels for a tag.
This commit refactors the CI so that patching the pyproject.toml file is no longer necessary. The (yet) private dependency project will be install directly from the Github repository as additional step before installing the rest of the test dependencies, and the Gitlab pipelines don't need to do anything special because they pull from an internal repository which hosts the dependency package.