-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add add_custom_diagrams
serializer
#134
base: main
Are you sure you want to change the base?
Conversation
input_str = ";".join( | ||
remove_width_and_height(eit).model_dump_json() | ||
for eit in elk_input | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be necessary and does not really look clean to me. You could argue that mocking the elk_input instead is fine as it should be tested in context_diagrams, but I would prefer to work with real input here to ensure that we know, if an update of context diagrams changes the rendering of diagrams
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The width
and height
calculations depend from the used platform (MacOS, Linux or Windows). They are not important for identifying if the context-diagram changed, the collected input elements are reliable and give developers the freedom of choice for their used platform without broken tests.
This removes unncessary iteration over all `work_items`.
87b1dbf
to
d9191c9
Compare
add_custom_diagrams
serializer
This PR adds the new
add_custom_diagrams
serializer. This serializer is configured like that:and therefore multiple custom diagrams can be added as custom fields to a work item. Also there is control about the
capella_attr
andpolarion_id
now.