Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add pdf exporter configuration #28

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

ewuerger
Copy link
Member

@ewuerger ewuerger commented Aug 8, 2024

This PR implements a cover page and a CSS stylesheet for the Polarion PDF Exporter plugin.

@ewuerger ewuerger added the enhancement New feature or request label Aug 8, 2024
@ewuerger ewuerger self-assigned this Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

The pull request does not conform to the conventional commit specification. Please ensure that your commit messages follow the spec: https://www.conventionalcommits.org/.
We also strongly recommend that you set up your development environment with pre-commit.

This is the commit validation log:

⧗   input: wip
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

⧗   input: wip
✖   subject may not be empty [subject-empty]
✖   type may not be empty [type-empty]

✖   found 2 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Here are some examples of valid commit messages:

feat(model): Add realized_states to State and Mode
fix(aird): Prevent creating circles with r=0
docs(readme): Update project description

@ewuerger ewuerger requested a review from micha91 August 8, 2024 08:24
Copy link
Contributor

@micha91 micha91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we include the weasyprint dockerfile here? Beside that LGTM

@ewuerger
Copy link
Member Author

Why do we include the weasyprint dockerfile here? Beside that LGTM

This was already approved, but I can remember that we argued to not version the extension config in here. Is that still true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants