Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend prettier setup #40

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

freshavocado7
Copy link
Contributor

The classes looked horrible.

  • eslint now triggers in pre-commit
  • prettier tailwind classes added to dev dependencies for cleaner tailwind classes

@freshavocado7 freshavocado7 force-pushed the refactor-improve-tailwind-classes-readability branch 3 times, most recently from 53e8df1 to 62775f5 Compare September 18, 2024 15:02
@Wuestengecko Wuestengecko force-pushed the refactor-improve-tailwind-classes-readability branch 2 times, most recently from a2984ad to e38e743 Compare September 25, 2024 14:38
@Wuestengecko
Copy link
Member

I tried rebasing, but now I'm stuck at a weird issue with prettier that I don't know how to resolve. It's determined to add a line containing only spaces, on line 117 of frontend/src/components/TemplateDetails.jsx:

https://github.com/DSD-DBS/capella-model-explorer/pull/40/files#diff-5d2e1b4fa1fbce56d2f60962989f23143e0a162127bff9b32980388810ed5bcfR117

This causes a clash with the trailing-whitespace hook. @freshavocado7 do you have an idea about this, or can take another look? Maybe it's a lot simpler than I think.

@freshavocado7
Copy link
Contributor Author

After a lot of back and forth with prettier i decided to just resolve it with string concatenation. Also added some more prettier-eslint configurations.

@freshavocado7 freshavocado7 force-pushed the refactor-improve-tailwind-classes-readability branch 2 times, most recently from 206ba7c to 97cdbcd Compare September 26, 2024 14:38
Run over JS/JSX files, and add a plugin to handle tailwind classes.
@Wuestengecko Wuestengecko force-pushed the refactor-improve-tailwind-classes-readability branch from 97cdbcd to 04ca35e Compare September 30, 2024 16:32
@Wuestengecko Wuestengecko changed the title refactor: Make tailwind classes prettier Extend prettier setup Sep 30, 2024
@Wuestengecko Wuestengecko merged commit ad9ea6a into master Sep 30, 2024
7 checks passed
@Wuestengecko Wuestengecko deleted the refactor-improve-tailwind-classes-readability branch September 30, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants