feat: Add print option for diagrams only #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewuerger
approved these changes
Jun 24, 2024
frontend/src/components/Lightbox.jsx
Outdated
Comment on lines
53
to
54
| setAdjustedHeight('100%'); | ||
| setAdjustedWidth('100%'); |
There was a problem hiding this comment.
Can't we initialize with '100%' in useState()? That would make the else case obsolete.
freshavocado7
force-pushed
the
feat-add-diagram-print-button
branch
from
2c43b6f to
2ea6bcc
Compare
freshavocado7
force-pushed
the
feat-add-diagram-print-button
branch
from
2ea6bcc to
d7b271b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The option to print a diagram has been added. When a diagram SVG is enlarged, a toolbar now appears at the top with options to print or close. Future features could include a slideshow of all diagrams, zoom in/zoom out, download image, and more.
In addition in order to enhance the user experience, larger SVGs are now being adjusted to fit the screen.
Closes: #5