Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci-templates): Fix broken aird check #210

Merged
merged 1 commit into from
Sep 25, 2023
Merged

fix(ci-templates): Fix broken aird check #210

merged 1 commit into from
Sep 25, 2023

Conversation

ewuerger
Copy link
Member

No description provided.

@ewuerger ewuerger self-assigned this Sep 22, 2023
Wuestengecko
Wuestengecko approved these changes Sep 22, 2023
View reviewed changes
Copy link
Member

@Wuestengecko Wuestengecko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this change that we made together.

Short explanation: The quotes inside the command substitution were swallowed by the YAML parser and didn't get through to the bash running this. That caused issues with paths and filenames that contain spaces, because bash. Single-quoting the entire line prevents the YAML parser from messing with it.

@ewuerger ewuerger enabled auto-merge September 22, 2023 15:21
@MoritzWeber0
Copy link
Member

I approve of this change that we made together.

Short explanation: The quotes inside the command substitution were swallowed by the YAML parser and didn't get through to the bash running this. That caused issues with paths and filenames that contain spaces, because bash. Single-quoting the entire line prevents the YAML parser from messing with it.

Thanks for debugging and the PR, @Wuestengecko and @ewuerger :)

@MoritzWeber0 MoritzWeber0 merged commit 233b0d5 into main Sep 25, 2023
17 of 18 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix-model-validation branch September 25, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 approved these changes

@Wuestengecko Wuestengecko Wuestengecko approved these changes

Assignees

@ewuerger ewuerger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewuerger @MoritzWeber0 @Wuestengecko