-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Lint all docker files with Hadolint #193
Conversation
22de589
to
c830ff8
Compare
7b5cd57
to
4e4b329
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition to our pre-commit here! It might make sense to close #119 as there is a clear rational behind having it and it doesn't hurt to have it (see DL4006).
In addition, I added one comment about moving the pre-commit job back to a separate file and use on
together with workflow_run
to create the dependency.
Also do not use a cache dir, as suggested by hadolint.
According to hadolint.
4e4b329
to
12340c6
Compare
So it can also be used in IDE's.
Fixes hadolint rule DL3002.
c087315
to
3c5da59
Compare
All |
Update dockerfiles to adhere to the (almost) default rule set of Hadolint.
I lowered the severity level of the following rules, since they would result in a change in the behabior of the dockerfiles.
DL3002 - Last user should not be root.DL3006
hadolint/hadolint#942)See #150. This adds Hadolint.
Initially I added hadolint as a pipeline step, however, I think it's way more effective as a pre-commit hook.
In order to function as a gate, I moved the pre-commit job in front og the build-and-deploy job.
NB. This PR remains in building state, since the pre-commit job has been merged with the build job.
May conflict with #119.