Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add promtail event filter #972

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Conversation

dominik003
Copy link
Contributor

For more information on this filter, please check out the comment in #941

Resolves #941

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch coverage: 12.50% and project coverage change: -0.77% ⚠️

Comparison is base (795684d) 71.11% compared to head (92f6eee) 70.34%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
- Coverage   71.11%   70.34%   -0.77%     
==========================================
  Files         153      155       +2     
  Lines        4729     5075     +346     
  Branches      504      565      +61     
==========================================
+ Hits         3363     3570     +207     
- Misses       1273     1406     +133     
- Partials       93       99       +6     
Files Changed Coverage Δ
backend/capellacollab/sessions/operators/k8s.py 35.20% <12.50%> (-1.37%) ⬇️

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Paula-Kli Paula-Kli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominik003 dominik003 changed the title Add promtail event filter feat: Add promtail event filter Sep 4, 2023
@dominik003 dominik003 force-pushed the feat-add-promtail-event-filter branch from 6a1f682 to 92f6eee Compare September 5, 2023 14:30
@MoritzWeber0 MoritzWeber0 merged commit 1e00fc8 into main Sep 6, 2023
21 of 23 checks passed
@MoritzWeber0 MoritzWeber0 deleted the feat-add-promtail-event-filter branch September 6, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore promtail events for session status derivation
3 participants