refactor: Group configuration-related API routes below /configurations
#2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zusorio
commented
Dec 9, 2024
zusorio
commented
- Move the web-based configuration code outside the settings folder
- Change the configuration API paths from /settings/configuration to /configuration
- Move the server-side config code inside the new top-level configuration folder into a new folder called app
API Changelog 4.14.1.dev36+g2e61d263GET /api/v1/configurations/global
PUT /api/v1/configurations/global
GET /api/v1/configurations/global/schema
GET /api/v1/configurations/unified
GET /api/v1/settings/configurations/global
PUT /api/v1/settings/configurations/global
GET /api/v1/settings/configurations/global/schema
GET /api/v1/settings/configurations/unified
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2067 +/- ##
==========================================
- Coverage 85.47% 85.46% -0.01%
==========================================
Files 224 224
Lines 7399 7397 -2
Branches 513 513
==========================================
- Hits 6324 6322 -2
Misses 911 911
Partials 164 164 ☔ View full report in Codecov by Sentry. |
|
A Storybook preview is available for commit 2e61d26. |
- Move the web-based configuration code outside the settings folder - Change the configuration API paths from /settings/configuration to /configuration - Move the server-side config code inside the new top-level configuration folder into a new folder called app
|
MoritzWeber0
approved these changes
Dec 9, 2024
MoritzWeber0
changed the title
/configurations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.