Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Group sessions by projects #2055

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

Show the project for read-only and provisioned sessions in the Active Sessions overview.

@MoritzWeber0 MoritzWeber0 force-pushed the group-sessions-by-projects branch from 40a3619 to e4506de Compare December 2, 2024 15:59
Copy link

github-actions bot commented Dec 2, 2024

API Changelog 4.14.1.dev26+g05d47c18

GET /api/v1/projects/{project_slug}/models/{model_slug}/provisioning

  • added the required property '/anyOf[subschema 1: ModelProvisioning]/session/anyOf[subschema 1: Session]/project' to the response with the '200' status

GET /api/v1/sessions

  • added the required property '/items/project' to the response with the '200' status

POST /api/v1/sessions

  • added the required property 'project' to the response with the '200' status

GET /api/v1/sessions/{session_id}

  • added the required property 'project' to the response with the '200' status

GET /api/v1/users/{user_id}/sessions

  • added the required property '/items/project' to the response with the '200' status

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (5436a1d) to head (12e73bd).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2055   +/-   ##
=======================================
  Coverage   85.46%   85.47%           
=======================================
  Files         225      225           
  Lines        7412     7416    +4     
  Branches      513      513           
=======================================
+ Hits         6335     6339    +4     
  Misses        913      913           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Dec 2, 2024

A Storybook preview is available for commit 05d47c1.
➡️ View Storybook
➡️ View Chromatic build

@MoritzWeber0 MoritzWeber0 requested a review from zusorio December 2, 2024 16:05

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the group-sessions-by-projects branch from e4506de to ba504d5 Compare December 2, 2024 16:10

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the group-sessions-by-projects branch from ba504d5 to 6ed087c Compare December 2, 2024 17:17
@MoritzWeber0 MoritzWeber0 force-pushed the group-sessions-by-projects branch from 6ed087c to 3095dbe Compare December 3, 2024 13:35

This comment has been minimized.

Show the project for read-only and provisioned sessions in the
Active Sessions overview.
@MoritzWeber0 MoritzWeber0 force-pushed the group-sessions-by-projects branch from 3095dbe to 12e73bd Compare December 5, 2024 09:29
Copy link

sonarcloud bot commented Dec 5, 2024

Copy link

github-actions bot commented Dec 5, 2024

This report was generated by comparing 05d47c1 with 5436a1d.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 352
change 30
new 40
delete 30
📝 Report

Differences

Model Components_Model Diagram Cache_Combined_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Combined_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Diagram Error_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Diagram Error_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Diagram Loaded_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Diagram Loaded_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Diagram Not Loaded_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Diagram Not Loaded_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Loading Without Scroll_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Loading Without Scroll_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_No Diagram For Filter_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_No Diagram For Filter_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_No Diagram_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Cache_No Diagram_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Job ID_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Job ID_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Token_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Token_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Session Overview_All Selected_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Session Overview_Overview_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Alert Settings_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Alert Settings_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Alert Settings_No Alerts_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Alert Settings_No Alerts_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Alert Settings_Some Alerts_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Alert Settings_Some Alerts_mobile.png

actual Actual
expected Expected
difference Difference

New Items

Session Components_Active Sessions_Few Active Sessions_desktop.png

NewItem

Session Components_Active Sessions_Few Active Sessions_mobile.png

NewItem

Session Components_Active Sessions_Grouped By Project Sessions_desktop.png

NewItem

Session Components_Active Sessions_Grouped By Project Sessions_mobile.png

NewItem

Session Components_Active Sessions_Grouped By Training Sessions Expanded_desktop.png

NewItem

Session Components_Active Sessions_Grouped By Training Sessions Expanded_mobile.png

NewItem

Session Components_Active Sessions_Grouped By Training Sessions_desktop.png

NewItem

Session Components_Active Sessions_Grouped By Training Sessions_mobile.png

NewItem

Session Components_Session Card_Readonly Session Success State_desktop.png

NewItem

Session Components_Session Card_Readonly Session Success State_mobile.png

NewItem

Session Components_Session Card_Session Failed State_desktop.png

NewItem

Session Components_Session Card_Session Failed State_mobile.png

NewItem

Session Components_Session Card_Session Not Found State_desktop.png

NewItem

Session Components_Session Card_Session Not Found State_mobile.png

NewItem

Session Components_Session Card_Session Pending State_desktop.png

NewItem

Session Components_Session Card_Session Pending State_mobile.png

NewItem

Session Components_Session Card_Session Preparation Pending State_desktop.png

NewItem

Session Components_Session Card_Session Preparation Pending State_mobile.png

NewItem

Session Components_Session Card_Session Preparation Running State_desktop.png

NewItem

Session Components_Session Card_Session Preparation Running State_mobile.png

NewItem

Session Components_Session Card_Session Running State_desktop.png

NewItem

Session Components_Session Card_Session Running State_mobile.png

NewItem

Session Components_Session Card_Session Shared With User Terminating Soon_desktop.png

NewItem

Session Components_Session Card_Session Shared With User Terminating Soon_mobile.png

NewItem

Session Components_Session Card_Session Shared With User_desktop.png

NewItem

Session Components_Session Card_Session Shared With User_mobile.png

NewItem

Session Components_Session Card_Session Sharing Enabled_desktop.png

NewItem

Session Components_Session Card_Session Sharing Enabled_mobile.png

NewItem

Session Components_Session Card_Session Terminated State_desktop.png

NewItem

Session Components_Session Card_Session Terminated State_mobile.png

NewItem

Session Components_Session Card_Session Terminating Soon_desktop.png

NewItem

Session Components_Session Card_Session Terminating Soon_mobile.png

NewItem

Session Components_Session Card_Session Unknown State_desktop.png

NewItem

Session Components_Session Card_Session Unknown State_mobile.png

NewItem

Session Components_Session Card_Session With Feedback Enabled_desktop.png

NewItem

Session Components_Session Card_Session With Feedback Enabled_mobile.png

NewItem

Session Components_Session Card_Shared Session_desktop.png

NewItem

Session Components_Session Card_Shared Session_mobile.png

NewItem

Settings Components_Alert Settings_Alert Expanded_desktop.png

NewItem

Settings Components_Alert Settings_Alert Expanded_mobile.png

NewItem

Deleted Items

Session Components_Active Sessions_Readonly Session Success State_desktop.png

DeleteItem

Session Components_Active Sessions_Readonly Session Success State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Failed State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Failed State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Not Found State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Not Found State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Pending State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Pending State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Preparation Pending State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Preparation Pending State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Preparation Running State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Preparation Running State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Running State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Running State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Shared With User Terminating Soon_desktop.png

DeleteItem

Session Components_Active Sessions_Session Shared With User Terminating Soon_mobile.png

DeleteItem

Session Components_Active Sessions_Session Shared With User_desktop.png

DeleteItem

Session Components_Active Sessions_Session Shared With User_mobile.png

DeleteItem

Session Components_Active Sessions_Session Sharing Enabled_desktop.png

DeleteItem

Session Components_Active Sessions_Session Sharing Enabled_mobile.png

DeleteItem

Session Components_Active Sessions_Session Terminated State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Terminated State_mobile.png

DeleteItem

Session Components_Active Sessions_Session Terminating Soon_desktop.png

DeleteItem

Session Components_Active Sessions_Session Terminating Soon_mobile.png

DeleteItem

Session Components_Active Sessions_Session Unknown State_desktop.png

DeleteItem

Session Components_Active Sessions_Session Unknown State_mobile.png

DeleteItem

Session Components_Active Sessions_Session With Feedback Enabled_desktop.png

DeleteItem

Session Components_Active Sessions_Session With Feedback Enabled_mobile.png

DeleteItem

Session Components_Active Sessions_Shared Session_desktop.png

DeleteItem

Session Components_Active Sessions_Shared Session_mobile.png

DeleteItem

@MoritzWeber0 MoritzWeber0 merged commit a5abcb7 into main Dec 5, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the group-sessions-by-projects branch December 5, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants