Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unify various API endpoints related to config #2034

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Nov 25, 2024

More details in the linked issue.

Closes #1960

Copy link

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

Copy link

github-actions bot commented Nov 25, 2024

API Changelog 4.14.1.dev32+g9ac4bfe4

GET /api/v1/configurations/feedback

  • ⚠️ api path removed without deprecation

GET /api/v1/metadata

  • ⚠️ api path removed without deprecation

GET /api/v1/navbar

  • ⚠️ api path removed without deprecation

GET /api/v1/settings/configurations/unified

  • endpoint added

GET /api/v1/users/beta

  • ⚠️ api path removed without deprecation

Copy link

github-actions bot commented Nov 25, 2024

A Storybook preview is available for commit 9ac4bfe.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (0b5d8c2) to head (4b70bc8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2034      +/-   ##
==========================================
- Coverage   85.47%   85.47%   -0.01%     
==========================================
  Files         225      224       -1     
  Lines        7416     7399      -17     
  Branches      513      513              
==========================================
- Hits         6339     6324      -15     
+ Misses        913      911       -2     
  Partials      164      164              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zusorio zusorio force-pushed the unified branch 2 times, most recently from 13a32d0 to 52c1225 Compare December 2, 2024 16:42

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zusorio zusorio force-pushed the unified branch 2 times, most recently from 6ec0890 to 3f7e658 Compare December 6, 2024 09:34

This comment has been minimized.

1 similar comment

This comment has been minimized.

This comment has been minimized.

More details in the linked issue.

Closes #1960
Copy link

sonarcloud bot commented Dec 6, 2024

Copy link

github-actions bot commented Dec 6, 2024

This report was generated by comparing 9ac4bfe with 0b5d8c2.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 422
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit b138d68 into main Dec 6, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the unified branch December 6, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine endpoints returning config
2 participants