Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Change idle time unavailable message if metrics not found #2032

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

MoritzWeber0
Copy link
Member

"Unknown session" could be interpreted as "The session doesn't exist", but that is not true. The session exists and only the metrics are not available.

@MoritzWeber0 MoritzWeber0 requested a review from zusorio November 21, 2024 12:12
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.46%. Comparing base (bb822af) to head (caa5a5e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2032   +/-   ##
=======================================
  Coverage   85.46%   85.46%           
=======================================
  Files         225      225           
  Lines        7412     7412           
  Branches      513      513           
=======================================
  Hits         6335     6335           
  Misses        913      913           
  Partials      164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

Copy link

github-actions bot commented Nov 21, 2024

API Changelog 4.14.1.dev4+g5658b442

This comment has been minimized.

"Unknown session" could be interpreted as "The session doesn't exist", but that
is not true. The session exists and only the metrics are not available.
Copy link

sonarcloud bot commented Nov 29, 2024

Copy link

This report was generated by comparing 5658b44 with bb822af.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 412
change 0
new 0
delete 0

Copy link
Member

@zusorio zusorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much clearer, nice 👍

@MoritzWeber0 MoritzWeber0 merged commit eda22af into main Dec 2, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the unknown-session branch December 2, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants