Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow customizing feedback hint and update dialog #1998

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Nov 14, 2024

  • Allow customizing the hint text.
  • Always show the text input to prevent layout shift
  • Enable dynamic sizing for hint to prevent layout issues

Copy link

github-actions bot commented Nov 14, 2024

API Changelog 4.13.1.dev36+g96e6f841

GET /api/v1/configurations/feedback

  • added the required property 'hint_text' to the response with the '200' status

GET /api/v1/settings/configurations/global

  • added the required property 'feedback/hint_text' to the response with the '200' status

PUT /api/v1/settings/configurations/global

  • added the new optional request property 'feedback/hint_text'
  • added the required property 'feedback/hint_text' to the response with the '200' status

Copy link

github-actions bot commented Nov 14, 2024

A Storybook preview is available for commit 96e6f84.
➡️ View Storybook
➡️ View Chromatic build

@zusorio zusorio force-pushed the feedback-custom-hint branch 3 times, most recently from 6b54144 to c14eef1 Compare November 14, 2024 14:57
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.62%. Comparing base (5c1976f) to head (6f39463).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1998   +/-   ##
=======================================
  Coverage   84.61%   84.62%           
=======================================
  Files         212      212           
  Lines        7067     7068    +1     
  Branches      493      493           
=======================================
+ Hits         5980     5981    +1     
  Misses        926      926           
  Partials      161      161           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

- Allow customizing the hint text.
- Always show the text input to prevent layout shift
- Enable dynamic sizing for hint to prevent layout issues
@zusorio zusorio force-pushed the feedback-custom-hint branch from c14eef1 to 6f39463 Compare November 14, 2024 15:05
Copy link

sonarcloud bot commented Nov 14, 2024

Copy link

This report was generated by comparing 96e6f84 with 5c1976f.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 352
change 8
new 6
delete 2
📝 Report

Differences

Session Components_Feedback_No Sessions_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_No Sessions_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_One Session_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_One Session_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Rating Selected_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Rating Selected_mobile.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Two Sessions_desktop.png

actual Actual
expected Expected
difference Difference

Session Components_Feedback_Two Sessions_mobile.png

actual Actual
expected Expected
difference Difference

New Items

Session Components_Feedback_Long Hint_desktop.png

NewItem

Session Components_Feedback_Long Hint_mobile.png

NewItem

Session Components_Feedback_One Session Without User Information_desktop.png

NewItem

Session Components_Feedback_One Session Without User Information_mobile.png

NewItem

Session Components_Feedback_Short Hint_desktop.png

NewItem

Session Components_Feedback_Short Hint_mobile.png

NewItem

Deleted Items

Session Components_Feedback_One Session With User Information_desktop.png

DeleteItem

Session Components_Feedback_One Session With User Information_mobile.png

DeleteItem

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use-case for it? How could an alternative text look like? The text is pretty generic and seems to fine for all environments from my view.

@zusorio
Copy link
Member Author

zusorio commented Nov 18, 2024

What is the use-case for it? How could an alternative text look like? The text is pretty generic and seems to fine for all environments from my view.

The idea behind this was to allow us to prompt users for extra info, like for example if they are in a certain office that might have wifi issues or similar things.

@MoritzWeber0 MoritzWeber0 merged commit a4caf85 into main Nov 18, 2024
31 checks passed
@MoritzWeber0 MoritzWeber0 deleted the feedback-custom-hint branch November 18, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants