-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow customizing feedback hint and update dialog #1998
Conversation
zusorio
commented
Nov 14, 2024
- Allow customizing the hint text.
- Always show the text input to prevent layout shift
- Enable dynamic sizing for hint to prevent layout issues
API Changelog 4.13.1.dev36+g96e6f841GET /api/v1/configurations/feedback
GET /api/v1/settings/configurations/global
PUT /api/v1/settings/configurations/global
|
A Storybook preview is available for commit 96e6f84. |
6b54144
to
c14eef1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1998 +/- ##
=======================================
Coverage 84.61% 84.62%
=======================================
Files 212 212
Lines 7067 7068 +1
Branches 493 493
=======================================
+ Hits 5980 5981 +1
Misses 926 926
Partials 161 161 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
- Allow customizing the hint text. - Always show the text input to prevent layout shift - Enable dynamic sizing for hint to prevent layout issues
c14eef1
to
6f39463
Compare
Quality Gate passedIssues Measures |
This report was generated by comparing 96e6f84 with 5c1976f. ArtifactName:
|
item | count |
---|---|
pass | 352 |
change | 8 |
new | 6 |
delete | 2 |
📝 Report
Differences
Session Components_Feedback_No Sessions_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Feedback_No Sessions_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Feedback_One Session_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Feedback_One Session_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Feedback_Rating Selected_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Feedback_Rating Selected_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_Feedback_Two Sessions_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_Feedback_Two Sessions_mobile.png
actual | |
---|---|
expected | |
difference |
New Items
Session Components_Feedback_Long Hint_desktop.png
Session Components_Feedback_Long Hint_mobile.png
Session Components_Feedback_One Session Without User Information_desktop.png
Session Components_Feedback_One Session Without User Information_mobile.png
Session Components_Feedback_Short Hint_desktop.png
Session Components_Feedback_Short Hint_mobile.png
Deleted Items
Session Components_Feedback_One Session With User Information_desktop.png
Session Components_Feedback_One Session With User Information_mobile.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the use-case for it? How could an alternative text look like? The text is pretty generic and seems to fine for all environments from my view.
The idea behind this was to allow us to prompt users for extra info, like for example if they are in a certain office that might have wifi issues or similar things. |