Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Consolidate session hook request arguments into one #1991

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

MoritzWeber0
Copy link
Member

This makes it easier in the future to extend the requests and allows better type annotations.

This makes it easier in the future to extend the requests and allows
better type annotations.
Copy link

sonarcloud bot commented Nov 13, 2024

Copy link

API Changelog 4.13.1.dev16+g91b5e00a

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (69221c4) to head (53f9559).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...kend/capellacollab/sessions/hooks/log_collector.py 28.57% 5 Missing ⚠️
backend/capellacollab/sessions/hooks/guacamole.py 62.50% 2 Missing and 1 partial ⚠️
...pellacollab/sessions/hooks/persistent_workspace.py 75.00% 0 Missing and 1 partial ⚠️
...apellacollab/sessions/hooks/read_only_workspace.py 50.00% 1 Missing ⚠️
backend/capellacollab/sessions/hooks/t4c.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1991      +/-   ##
==========================================
+ Coverage   84.58%   84.70%   +0.11%     
==========================================
  Files         212      212              
  Lines        7032     7093      +61     
  Branches      492      497       +5     
==========================================
+ Hits         5948     6008      +60     
  Misses        924      924              
- Partials      160      161       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This report was generated by comparing 91b5e00 with 69221c4.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 358
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit 1b940f4 into main Nov 13, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the restructure-hooks branch November 13, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant