Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Replace 'default' with 'regular' image in alebmic migration #1983

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

MoritzWeber0
Copy link
Member

The migration was wrong, leading to an invalid configuration.

Copy link

github-actions bot commented Nov 12, 2024

API Changelog 4.12.1.dev14+g1319abaf

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.71%. Comparing base (c6d2508) to head (d13f798).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1983   +/-   ##
=======================================
  Coverage   84.71%   84.71%           
=======================================
  Files         211      211           
  Lines        6995     6995           
  Branches      491      491           
=======================================
  Hits         5926     5926           
  Misses        906      906           
  Partials      163      163           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

The migration was wrong, leading to an invalid configuration.
@MoritzWeber0 MoritzWeber0 changed the base branch from promtail-sep-pod to main November 12, 2024 21:46
Copy link

sonarcloud bot commented Nov 12, 2024

Copy link

This report was generated by comparing 1319aba with c6d2508.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 358
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit 31743d0 into main Nov 12, 2024
15 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix-image-migration branch November 12, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant