Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Move promtail container to external Pod #1982

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

Resolves #1980

Copy link

github-actions bot commented Nov 12, 2024

API Changelog 4.12.1.dev16+g631be091

This comment has been minimized.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 58.06452% with 26 lines in your changes missing coverage. Please review.

Project coverage is 84.58%. Comparing base (31743d0) to head (70a993c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...kend/capellacollab/sessions/hooks/log_collector.py 51.42% 17 Missing ⚠️
backend/capellacollab/sessions/operators/k8s.py 52.63% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1982      +/-   ##
==========================================
- Coverage   84.71%   84.58%   -0.14%     
==========================================
  Files         211      212       +1     
  Lines        6995     7032      +37     
  Branches      491      492       +1     
==========================================
+ Hits         5926     5948      +22     
- Misses        906      924      +18     
+ Partials      163      160       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

@MoritzWeber0 MoritzWeber0 force-pushed the promtail-sep-pod branch 2 times, most recently from c894534 to 275b1be Compare November 12, 2024 22:01

This comment has been minimized.

This comment has been minimized.

Copy link

sonarcloud bot commented Nov 12, 2024

Copy link

This report was generated by comparing 631be09 with 31743d0.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 358
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit 6156e34 into main Nov 12, 2024
29 of 30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the promtail-sep-pod branch November 12, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move non-critical session containers to external Pod
1 participant