Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle case where container_statuses is None #1973

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

MoritzWeber0
Copy link
Member

status.container_statuses can be None. In this case, return UNKNOWN as status.

`status.container_statuses` can be `None`. In this case,
return `UNKNOWN` as status.
Copy link

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.63%. Comparing base (b95a194) to head (939d2eb).

Files with missing lines Patch % Lines
backend/capellacollab/sessions/operators/k8s.py 78.57% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1973      +/-   ##
==========================================
- Coverage   84.64%   84.63%   -0.02%     
==========================================
  Files         211      211              
  Lines        6944     6945       +1     
  Branches      482      483       +1     
==========================================
  Hits         5878     5878              
  Misses        904      904              
- Partials      162      163       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

API Changelog 4.12.1.dev4+geea2792f

Copy link

This report was generated by comparing eea2792 with b95a194.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 342
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit 8960a7e into main Nov 11, 2024
29 of 30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the container-statuses-fix branch November 11, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant