Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add the ability to set a company logo and show environment badge #1936

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Oct 29, 2024

Add the ability to set a logo that will be displayed next to the Capella text. Add a badge that can show the current environment with different UI depending on if the environment is productive. The badge is enabled during development by default.

@zusorio zusorio requested a review from MoritzWeber0 as a code owner October 29, 2024 18:17
Copy link

github-actions bot commented Oct 29, 2024

API Changelog 4.14.1.dev40+g80ffd620

GET /api/v1/configurations/global

  • added the required property 'navbar/badge' to the response with the '200' status
  • added the required property 'navbar/logo_url' to the response with the '200' status

PUT /api/v1/configurations/global

  • added the new optional request property 'navbar/badge'
  • added the new optional request property 'navbar/logo_url'
  • added the required property 'navbar/badge' to the response with the '200' status
  • added the required property 'navbar/logo_url' to the response with the '200' status

GET /api/v1/configurations/unified

  • added the required property 'navbar/badge' to the response with the '200' status
  • added the required property 'navbar/logo_url' to the response with the '200' status

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.49%. Comparing base (73c7fc5) to head (bf71e85).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
backend/capellacollab/configuration/util.py 87.50% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1936      +/-   ##
==========================================
+ Coverage   85.46%   85.49%   +0.02%     
==========================================
  Files         224      224              
  Lines        7397     7423      +26     
  Branches      513      519       +6     
==========================================
+ Hits         6322     6346      +24     
  Misses        911      911              
- Partials      164      166       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

Copy link

github-actions bot commented Oct 29, 2024

A Storybook preview is available for commit 80ffd62.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The navigation bar looks way cleaner now 👍

backend/capellacollab/navbar/routes.py Outdated Show resolved Hide resolved
backend/capellacollab/navbar/routes.py Outdated Show resolved Hide resolved
backend/capellacollab/navbar/routes.py Outdated Show resolved Hide resolved
frontend/src/app/general/logo/logo.stories.ts Outdated Show resolved Hide resolved
frontend/src/app/general/logo/logo.component.html Outdated Show resolved Hide resolved
frontend/tailwind.config.js Outdated Show resolved Hide resolved
frontend/src/app/general/logo/logo.component.html Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Dec 2, 2024

The generated OpenAPI client is not up to date with the latest changes in the OpenAPI specification.
Please run make openapi locally and commit the changes.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zusorio zusorio force-pushed the custom-logos branch 2 times, most recently from 1fa9e6d to b5af082 Compare December 2, 2024 16:02

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@zusorio zusorio force-pushed the custom-logos branch 3 times, most recently from 99caba4 to 4d11151 Compare December 9, 2024 14:40
Add the ability to set a logo that will be displayed next to the Capella text. Add a badge that can
show the current environment with different UI depending on if the environment is productive. The
badge is enabled during development by default.
Copy link

sonarcloud bot commented Dec 9, 2024

This comment has been minimized.

1 similar comment
Copy link

github-actions bot commented Dec 9, 2024

ArtifactName: reg

Failed to find a target artifact.
All items will be treated as new items and will be used as expected data for the next time.

target not found

item count
new 432

@MoritzWeber0 MoritzWeber0 merged commit bc6e9d1 into main Dec 9, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the custom-logos branch December 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants