Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metrics about the SQLAlchemy database pool #1925

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

MoritzWeber0
Copy link
Member

Adds the following to the /metrics endpoint:

# HELP sqlalchemy_pool_size SQLAlchemy database connection pool size
# TYPE sqlalchemy_pool_size gauge
sqlalchemy_pool_size 20.0
# HELP sqlalchemy_connections_in_pool Available database connections in the SQLAlchemy pool
# TYPE sqlalchemy_connections_in_pool gauge
sqlalchemy_connections_in_pool 1.0
# HELP sqlalchemy_pool_overflow Overflow of the SQLAlchemy database connection pool
# TYPE sqlalchemy_pool_overflow gauge
sqlalchemy_pool_overflow -19.0
# HELP sqlalchemy_checked_out_connections Checked out SQLAlchemy database connections
# TYPE sqlalchemy_checked_out_connections gauge
sqlalchemy_checked_out_connections 0.0

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 89.74359% with 4 lines in your changes missing coverage. Please review.

Project coverage is 84.70%. Comparing base (ce5cb51) to head (c113366).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
backend/capellacollab/core/database/metrics.py 86.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1925      +/-   ##
==========================================
+ Coverage   84.68%   84.70%   +0.02%     
==========================================
  Files         206      208       +2     
  Lines        6739     6774      +35     
  Branches      463      463              
==========================================
+ Hits         5707     5738      +31     
- Misses        870      874       +4     
  Partials      162      162              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Oct 24, 2024

API Changelog 4.8.3.dev11+g97dc5282

Base automatically changed from pool-size to main October 24, 2024 10:16

This comment has been minimized.

Copy link

sonarcloud bot commented Oct 24, 2024

Copy link

This report was generated by comparing 97dc528 with ce5cb51.
If you would like to check difference, please check here.

success

ArtifactName: reg

✨✨ That's perfect, there is no visual difference! ✨✨

item count
pass 342
change 0
new 0
delete 0

@MoritzWeber0 MoritzWeber0 merged commit 9f017c0 into main Oct 24, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the pool-size-metrics branch October 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants