fix: Fix an issue where feedback that shared contact info was not sent #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feedback emails are sent in a background task to decrease response latency. Unfortunately, this means that the SQLAlchemy session is already closed and none of the fields of DatabaseUser can be resolved. This bug was not found because the error messages are swallowed by the background task. The bug is fixed by turning the DatabaseUser object into a normal User object before passing it to the background task.
API Changelog 4.8.1.dev3+g138106ca |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1909 +/- ##
==========================================
- Coverage 84.72% 84.69% -0.04%
==========================================
Files 206 206
Lines 6737 6741 +4
Branches 464 463 -1
==========================================
+ Hits 5708 5709 +1
- Misses 867 870 +3
Partials 162 162 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feedback emails are sent in a background task to decrease response latency. Unfortunately, this means that the SQLAlchemy session is already closed and none of the fields of DatabaseUser can be resolved. This bug was not found because the error messages are swallowed by the background task. The bug is fixed by turning the DatabaseUser object into a normal User object before passing it to the background task.