-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Rewrite major parts of the file browser #1873
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
==========================================
- Coverage 84.44% 84.06% -0.38%
==========================================
Files 197 197
Lines 6549 6716 +167
Branches 729 768 +39
==========================================
+ Hits 5530 5646 +116
- Misses 859 904 +45
- Partials 160 166 +6 ☔ View full report in Codecov by Sentry. |
A Storybook preview is available for commit 37fc7a3. |
This comment has been minimized.
This comment has been minimized.
a415e77
to
479761b
Compare
This comment has been minimized.
This comment has been minimized.
...user-sessions-wrapper/active-sessions/file-browser-dialog/file-browser-dialog.component.html
Outdated
Show resolved
Hide resolved
479761b
to
9af5cd8
Compare
This comment has been minimized.
This comment has been minimized.
9af5cd8
to
fd9cc20
Compare
This comment has been minimized.
This comment has been minimized.
fd9cc20
to
34b09d5
Compare
This comment has been minimized.
This comment has been minimized.
Breaking API change: `filename` was renamed to `path` in `/api/v1/sessions/{session_id}/files/download` to make it consistent with the the list files endpoint. - The UI got an overhaul - margins are fixed and more icons for different cases were added (added files, modified files, expanded folder) - The workspace is now expanded per default - Download of single files (not directories) was added - Replaced brute force to find a path with path traversal, which is a lot more efficient - Use the generated OpenAPI client, fix API docs to use ZIP as response - Migrate to TailwindCSS - Remove custom "Overwrite file" dialog, replace with ConfirmationDialog. - Remove `NestedTreeControl` - Separate handling for files which replace existing files - Stream downloading directory directory without loading to memory - Fix a bug that files with special characters couldn't be downloaded (archive had a size of 0KB)
34b09d5
to
35c1aa1
Compare
Quality Gate passedIssues Measures |
This report was generated by comparing 37fc7a3 with 8601089. ArtifactName:
|
item | count |
---|---|
pass | 298 |
change | 12 |
new | 0 |
delete | 0 |
📝 Report
Differences
Session Components_File Browser_Download Preparation_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Download Preparation_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Files_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Files_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Loading Files_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Loading Files_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Upload In Progress_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Upload In Progress_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Upload New File_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Upload New File_mobile.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Upload Processed By Backend_desktop.png
actual | |
---|---|
expected | |
difference |
Session Components_File Browser_Upload Processed By Backend_mobile.png
actual | |
---|---|
expected | |
difference |
Breaking API change:
filename
was renamed topath
in/api/v1/sessions/{session_id}/files/download
to make it consistent with the the list files endpoint.NestedTreeControl
, resolves Remove usage ofNestedTreeControl
#1732Resolves #118 except upload limit (will be kept to reduce load on the backend) + different file icons for different extensions (not planned).