Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add delay to let mat-error animation complete #1842

Merged
merged 2 commits into from
Sep 25, 2024
Merged

test: Add delay to let mat-error animation complete #1842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48606c1
test: Add delay to let mat-error animation complete
MoritzWeber0 Sep 25, 2024
5907403
fix: Disable spell checking for API URL
MoritzWeber0 Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...end/src/app/projects/models/model-source/git/manage-git-model/manage-git-model.stories.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,11 @@ export default meta;
type Story = StoryObj<ManageGitModelComponent>;

export const InvalidURL: Story = {
args: {},
parameters: {
screenshot: {
delay: 300,
},
},
play: async ({ canvasElement }) => {
const canvas = within(canvasElement);
const absoluteURL = canvas.getByTestId('absolute-url');
Expand Down
7 changes: 6 additions & 1 deletion ...c/app/settings/modelsources/git-settings/add-git-instance/add-git-instance.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,12 @@ <h2 class="mb-2 text-xl font-medium">Link a Git Server Instance</h2>
@if (gitInstancesForm.controls.type.value !== "General") {
<mat-form-field class="form-field-default" appearance="fill">
<mat-label>API Base URL</mat-label>
<input matInput formControlName="api_url" data-testid="api_url" />
<input
matInput
spellcheck="false"
formControlName="api_url"
data-testid="api_url"
/>
@if (gitInstancesForm.controls.url.errors?.urlSchemeError) {
<mat-error> API URLs have to start with 'http(s)://' </mat-error>
}
Expand Down
Loading