Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Apply new code style and write Stories for Git components #1838

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

MoritzWeber0
Copy link
Member

No description provided.

Copy link

sonarcloud bot commented Sep 24, 2024

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.01%. Comparing base (b5a038d) to head (7690399).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage   84.01%   84.01%           
=======================================
  Files         194      194           
  Lines        6455     6455           
  Branches      713      713           
=======================================
  Hits         5423     5423           
  Misses        876      876           
  Partials      156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

This report was generated by comparing 3e81e9a with b5a038d.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 238
change 28
new 22
delete 0
📝 Report

Differences

Model Components_Model Diagram Code Block_Code Block With Job ID_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Job ID_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Token_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block With Token_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Diagram Code Block_Code Block_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_Loading As Admin_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_Loading As Admin_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_With Repository As Admin_desktop.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_With Repository As Admin_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_Request Sent_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_Request Sent_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_With Linked Models_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Create Backup_With Linked Models_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Admin_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Admin_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Project Admin_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_As Project Admin_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_Request Sent_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Pipeline Deletion Dialog_Request Sent_mobile.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Trigger Pipeline_Pipeline Overview_desktop.png

actual Actual
expected Expected
difference Difference

Pipeline Components_Trigger Pipeline_Pipeline Overview_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_Git_Instances_General_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_Git_Instances_General_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Overview_desktop.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

New Items

Model Components_Model Sources_Git_Existing Git Model Editing_desktop.png

NewItem

Model Components_Model Sources_Git_Existing Git Model Editing_mobile.png

NewItem

Model Components_Model Sources_Git_Existing Git Model_desktop.png

NewItem

Model Components_Model Sources_Git_Existing Git Model_mobile.png

NewItem

Model Components_Model Sources_Git_Invalid URL_desktop.png

NewItem

Model Components_Model Sources_Git_Invalid URL_mobile.png

NewItem

Model Components_Model Sources_Git_Valid URL_desktop.png

NewItem

Model Components_Model Sources_Git_Valid URL_mobile.png

NewItem

Settings Components_Modelsources_Git_Add Instance_General Selected_desktop.png

NewItem

Settings Components_Modelsources_Git_Add Instance_General Selected_mobile.png

NewItem

Settings Components_Modelsources_Git_Add Instance_With Values_desktop.png

NewItem

Settings Components_Modelsources_Git_Add Instance_With Values_mobile.png

NewItem

Settings Components_Modelsources_Git_Add Instance_Without Values_desktop.png

NewItem

Settings Components_Modelsources_Git_Add Instance_Without Values_mobile.png

NewItem

Settings Components_Modelsources_Git_Edit Instance_General_desktop.png

NewItem

Settings Components_Modelsources_Git_Edit Instance_General_mobile.png

NewItem

Settings Components_Modelsources_Git_Edit Instance_Github_desktop.png

NewItem

Settings Components_Modelsources_Git_Edit Instance_Github_mobile.png

NewItem

Settings Components_Modelsources_Git_Instances_Loading_desktop.png

NewItem

Settings Components_Modelsources_Git_Instances_Loading_mobile.png

NewItem

Settings Components_Overview_General_desktop.png

NewItem

Settings Components_Overview_General_mobile.png

NewItem

Copy link

A Storybook preview is available for commit 3e81e9a.
➡️ View Storybook
➡️ View Chromatic build

@MoritzWeber0 MoritzWeber0 merged commit a97f2df into main Sep 24, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the git-repository-link branch September 24, 2024 17:07
MoritzWeber0 added a commit that referenced this pull request Oct 4, 2024
Add `resultUrlPrefixAsyncValidator` again. Was removed in
#1838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant