-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Display long usernames correctly in user overview #1820
Conversation
MoritzWeber0
commented
Sep 21, 2024
•
edited
Loading
edited
- Rename the existing userService to ownUserWrapperService
- Create a new userWrapperService and userWrapperComponent, which keeps track of the list of registered users and the currently selected user via path parameters
- Migrate the components to use the new userWrapperService
- Remove bottom padding for project user and user components
A Storybook preview is available for commit 21d0b1d. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1820 +/- ##
=======================================
Coverage 84.13% 84.13%
=======================================
Files 194 194
Lines 6442 6442
Branches 709 709
=======================================
Hits 5420 5420
Misses 867 867
Partials 155 155 ☔ View full report in Codecov by Sentry. |
This comment has been minimized.
This comment has been minimized.
4aeba34
to
8e08bdf
Compare
This comment has been minimized.
This comment has been minimized.
8e08bdf
to
220968d
Compare
This comment has been minimized.
This comment has been minimized.
- Rename the existing userService to ownUserWrapperService - Create a new userWrapperService and userWrapperComponent, which keeps track of the list of registered users and the currently selected user via path parameters - Migrate the components to use the new userWrapperService - Remove bottom padding for project user and user components - Improve responsive design
220968d
to
86f9de9
Compare
Quality Gate passedIssues Measures |
This report was generated by comparing 21d0b1d with 39e13b5. ArtifactName:
|
item | count |
---|---|
pass | 245 |
change | 15 |
new | 6 |
delete | 2 |
📝 Report
Differences
Model Components_Model Overview_As Global Admin_mobile.png
actual | |
---|---|
expected | |
difference |
Model Components_Model Overview_As Project Admin_mobile.png
actual | |
---|---|
expected | |
difference |
Model Components_Model Overview_Overview_mobile.png
actual | |
---|---|
expected | |
difference |
Model Components_Model Sources_Overview_Loading As Admin_mobile.png
actual | |
---|---|
expected | |
difference |
Model Components_Model Sources_Overview_Loading_mobile.png
actual | |
---|---|
expected | |
difference |
Model Components_Model Sources_Overview_With Repository As Admin_mobile.png
actual | |
---|---|
expected | |
difference |
Project Components_Project Details_Loading As Project Lead_desktop.png
actual | |
---|---|
expected | |
difference |
Project Components_Project Overview_Loading_mobile.png
actual | |
---|---|
expected | |
difference |
Project Components_Project Overview_Overview_mobile.png
actual | |
---|---|
expected | |
difference |
Project Components_Project Users_Loading_desktop.png
actual | |
---|---|
expected | |
difference |
Project Components_Project Users_Loading_mobile.png
actual | |
---|---|
expected | |
difference |
Project Components_Project Users_Overview_desktop.png
actual | |
---|---|
expected | |
difference |
Project Components_Project Users_Overview_mobile.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Overview_Loading_mobile.png
actual | |
---|---|
expected | |
difference |
Settings Components_Modelsources_T4C_Server Overview_Overview_mobile.png
actual | |
---|---|
expected | |
difference |