Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Display long usernames correctly in user overview #1820

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Sep 21, 2024

  • Rename the existing userService to ownUserWrapperService
  • Create a new userWrapperService and userWrapperComponent, which keeps track of the list of registered users and the currently selected user via path parameters
  • Migrate the components to use the new userWrapperService
  • Remove bottom padding for project user and user components

Copy link

github-actions bot commented Sep 21, 2024

A Storybook preview is available for commit 21d0b1d.
➡️ View Storybook
➡️ View Chromatic build
✅ Captured 42 snapshots. No changes detected.

Copy link

codecov bot commented Sep 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.13%. Comparing base (39e13b5) to head (86f9de9).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1820   +/-   ##
=======================================
  Coverage   84.13%   84.13%           
=======================================
  Files         194      194           
  Lines        6442     6442           
  Branches      709      709           
=======================================
  Hits         5420     5420           
  Misses        867      867           
  Partials      155      155           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

- Rename the existing userService to ownUserWrapperService
- Create a new userWrapperService and userWrapperComponent,
  which keeps track of the list of registered users and the currently
  selected user via path parameters
- Migrate the components to use the new userWrapperService
- Remove bottom padding for project user and user components
- Improve responsive design
Copy link

sonarcloud bot commented Sep 23, 2024

Copy link

This report was generated by comparing 21d0b1d with 39e13b5.
If you would like to check difference, please check here.

change detected

ArtifactName: reg

item count
pass 245
change 15
new 6
delete 2
📝 Report

Differences

Model Components_Model Overview_As Global Admin_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_As Project Admin_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_Loading As Admin_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Model Components_Model Sources_Overview_With Repository As Admin_mobile.png

actual Actual
expected Expected
difference Difference

Project Components_Project Details_Loading As Project Lead_desktop.png

actual Actual
expected Expected
difference Difference

Project Components_Project Overview_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Project Components_Project Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

Project Components_Project Users_Loading_desktop.png

actual Actual
expected Expected
difference Difference

Project Components_Project Users_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Project Components_Project Users_Overview_desktop.png

actual Actual
expected Expected
difference Difference

Project Components_Project Users_Overview_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Loading_mobile.png

actual Actual
expected Expected
difference Difference

Settings Components_Modelsources_T4C_Server Overview_Overview_mobile.png

actual Actual
expected Expected
difference Difference

New Items

Settings Components_User Settings_Loading_desktop.png

NewItem

Settings Components_User Settings_Loading_mobile.png

NewItem

Settings Components_User Settings_Overview_desktop.png

NewItem

Settings Components_User Settings_Overview_mobile.png

NewItem

Settings Components_Users Profile_User Workspaces_Workspace Overview_desktop.png

NewItem

Settings Components_Users Profile_User Workspaces_Workspace Overview_mobile.png

NewItem

Deleted Items

Settings Components_Users Profile_User Workspaces_Workspace_desktop.png

DeleteItem

Settings Components_Users Profile_User Workspaces_Workspace_mobile.png

DeleteItem

@MoritzWeber0 MoritzWeber0 merged commit ca4d4ee into main Sep 23, 2024
32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the users-overview branch September 23, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant