Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: More migration to new Angular control flow #1804

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Sep 16, 2024

No description provided.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (69159ef) to head (7ac0abb).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1804      +/-   ##
==========================================
+ Coverage   84.60%   84.69%   +0.08%     
==========================================
  Files         203      203              
  Lines        6691     6691              
  Branches      742      457     -285     
==========================================
+ Hits         5661     5667       +6     
  Misses        866      866              
+ Partials      164      158       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0
Copy link
Member

Hey @zusorio, great that you're looking into the migration of the control flow. We decided some time ago in the team to do it iteratively and to add stories for each touched component. So make sure that all components moved to the new control flow have stories if they make sense. If you spot CSS that can be moved to Tailwind, that's also a good place to do it. But as far as I can see, you're already on the right track :)

@zusorio zusorio force-pushed the more-new-control-flow branch from 9a16d71 to db612f4 Compare September 23, 2024 10:12
@zusorio zusorio marked this pull request as ready for review September 23, 2024 10:14
Copy link

github-actions bot commented Sep 23, 2024

A Storybook preview is available for commit f9ce15d.
➡️ View Storybook
➡️ View Chromatic build

This comment has been minimized.

This comment has been minimized.

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit thanks for the migration and the stories 🫶
I have some smaller comments, in some cases I'd also add additional stories for specific cases.

@zusorio zusorio force-pushed the more-new-control-flow branch from 9d196bf to 25c1147 Compare October 7, 2024 10:41

This comment has been minimized.

@zusorio zusorio force-pushed the more-new-control-flow branch from 25c1147 to 3048bb7 Compare October 8, 2024 11:22

This comment has been minimized.

@zusorio zusorio force-pushed the more-new-control-flow branch from 3048bb7 to 4160d76 Compare October 8, 2024 11:31

This comment has been minimized.

@zusorio zusorio force-pushed the more-new-control-flow branch from 4160d76 to 5e49b07 Compare October 8, 2024 11:35

This comment has been minimized.

@zusorio zusorio force-pushed the more-new-control-flow branch from 5e49b07 to 5f081b1 Compare October 8, 2024 12:02

This comment has been minimized.

@zusorio zusorio force-pushed the more-new-control-flow branch from 5f081b1 to 0910006 Compare October 8, 2024 12:20

This comment has been minimized.

@zusorio zusorio requested a review from MoritzWeber0 October 9, 2024 07:17
Copy link

sonarcloud bot commented Oct 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a million, especially for all of those great new stories 💯

@MoritzWeber0 MoritzWeber0 enabled auto-merge October 9, 2024 13:57
Copy link

github-actions bot commented Oct 9, 2024

This report was generated by comparing f9ce15d with 69159ef.
If you would like to check difference, please check here.

new items

ArtifactName: reg

item count
pass 318
change 0
new 22
delete 0
📝 Report

New Items

Model Components_Init Model_General_desktop.png

NewItem

Model Components_Init Model_General_mobile.png

NewItem

Project Components_Audit Log_General_desktop.png

NewItem

Project Components_Audit Log_General_mobile.png

NewItem

Project Components_Audit Log_Loading_desktop.png

NewItem

Project Components_Audit Log_Loading_mobile.png

NewItem

Project Components_Create Project_Add Model_desktop.png

NewItem

Project Components_Create Project_Add Model_mobile.png

NewItem

Project Components_Create Project_Add Team Members_desktop.png

NewItem

Project Components_Create Project_Add Team Members_mobile.png

NewItem

Project Components_Create Project_Create Project_desktop.png

NewItem

Project Components_Create Project_Create Project_mobile.png

NewItem

Project Components_Project Details_Edit Project Metadata_General_desktop.png

NewItem

Project Components_Project Details_Edit Project Metadata_General_mobile.png

NewItem

Project Components_Project Details_Edit Project Metadata_With Title_desktop.png

NewItem

Project Components_Project Details_Edit Project Metadata_With Title_mobile.png

NewItem

Settings Components_Pipelines Overview_Bad Health_desktop.png

NewItem

Settings Components_Pipelines Overview_Bad Health_mobile.png

NewItem

Settings Components_Pipelines Overview_Good Health_desktop.png

NewItem

Settings Components_Pipelines Overview_Good Health_mobile.png

NewItem

Settings Components_Pipelines Overview_Loading_desktop.png

NewItem

Settings Components_Pipelines Overview_Loading_mobile.png

NewItem

@MoritzWeber0 MoritzWeber0 merged commit 72564da into main Oct 9, 2024
31 of 32 checks passed
@MoritzWeber0 MoritzWeber0 deleted the more-new-control-flow branch October 9, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants