fix: Remove small pixel differences in diagram cache dialog #1802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1802 +/- ##
=======================================
Coverage 84.18% 84.18%
=======================================
Files 186 186
Lines 6159 6159
Branches 677 677
=======================================
Hits 5185 5185
Misses 826 826
Partials 148 148 ☔ View full report in Codecov by Sentry. |
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
d3da269 to
ebf4527
Compare
|
A Storybook preview is available for commit 5934f2c. |
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
ebf4527 to
97306b8
Compare
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
97306b8 to
94241ce
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
reg-actions
branch
2 times, most recently
from
20d2f1e to
300161c
Compare
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
94241ce to
f15931b
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
reg-actions
branch
from
300161c to
6a4d330
Compare
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
f15931b to
c861a19
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
reg-actions
branch
from
6a4d330 to
5697f38
Compare
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
c861a19 to
a19bb0b
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
reg-actions
branch
from
5697f38 to
bdf3557
Compare
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
a19bb0b to
f421eb2
Compare
MoritzWeber0
force-pushed
the
reg-actions
branch
from
bdf3557 to
ac74390
Compare
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
f421eb2 to
1ae83f9
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
1ae83f9 to
c7d2fda
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
reg-actions
branch
from
ac74390 to
e59d1f4
Compare
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
c7d2fda to
e3eac12
Compare
This comment has been minimized.
This comment has been minimized.
MoritzWeber0
force-pushed
the
reg-actions
branch
2 times, most recently
from
e9bd352 to
ce6c33a
Compare
MoritzWeber0
force-pushed
the
reg-actions
branch
from
ce6c33a to
331d0dc
Compare
…adge Small pixel differences led to small jumps when the diagram cache was loaded. It feels smoother now. Same applies to the model complexity badge.
MoritzWeber0
force-pushed
the
diagram-cache-ui
branch
from
e3eac12 to
87e4f37
Compare
|
|
This report was generated by comparing 5934f2c with 74f6b81. ArtifactName:
|
| item | count |
|---|---|
| pass | 228 |
| change | 14 |
| new | 2 |
| delete | 0 |
📝 Report
Differences
Model Components_Model Complexity Badge_Git Instance Endpoint Undefined.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Complexity Badge_Loading.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Complexity Badge_No Job Configured.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Complexity Badge_Pipeline Job Not Found.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Complexity Badge_Successful.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Combined_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Combined_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Diagram Error_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Diagram Error_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Diagram Not Loaded_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Diagram Not Loaded_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Loading_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Diagram Cache_Loading_mobile.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
Model Components_Model Overview_Overview_desktop.png
| actual |  |
|---|---|
| expected |  |
| difference |  |
New Items
Model Components_Model Diagram Cache_Loading Without Scroll_desktop.png
 |
Model Components_Model Diagram Cache_Loading Without Scroll_mobile.png
 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small pixel differences led to small jumps when the diagram cache was loaded. It feels smoother now.