Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide welcome banner on small screens #1797

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Sep 12, 2024

On small screens, the welcome banner is unnecessary clutter. Hide it on anything that's less tall than a 1080p monitor.

Closes #1786

On small screens, the welcome banner is unnecessary clutter.
Hide it on anything that's less tall than a 1080p monitor.

Closes #1786
Copy link

github-actions bot commented Sep 12, 2024

A Storybook preview is available for commit 85b4cef.
➡️ View Storybook
➡️ View Chromatic build
✅ Captured 27 snapshots. No changes detected.

Copy link

sonarcloud bot commented Sep 12, 2024

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.06%. Comparing base (f43efb9) to head (a43b2c1).
Report is 361 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1797   +/-   ##
=======================================
  Coverage   84.06%   84.06%           
=======================================
  Files         186      186           
  Lines        6144     6144           
  Branches      676      676           
=======================================
  Hits         5165     5165           
  Misses        831      831           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MoritzWeber0 MoritzWeber0 merged commit 7fd8d6f into main Sep 12, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the hide-welcome-on-small-screens branch September 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider removing the welcome banner from the sessions view
2 participants