Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrate more code to @if #1754

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

zusorio
Copy link
Member

@zusorio zusorio commented Sep 5, 2024

This migrates some more components to Angular 17's new control flow and adds stories for them. It also deletes a component that was not being used.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (690ff5c) to head (419d6a9).
Report is 373 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1754   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files         186      186           
  Lines        6137     6137           
  Branches      675      675           
=======================================
  Hits         5158     5158           
  Misses        831      831           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts with the base branch, they have to be resolved.

@zusorio zusorio force-pushed the new-angular-control-flow branch from 56cc673 to 76c8f65 Compare September 5, 2024 17:10
Copy link

github-actions bot commented Sep 5, 2024

A Storybook preview is available for commit 39a88c2.
➡️ View Storybook
➡️ View Chromatic build
🔍 11 out of 91 snapshots have changed. Please review the changes before merging.

This migrates some more components to Angular 17's new control flow and adds stories for them.
It also deletes a component that was not being used.
@MoritzWeber0 MoritzWeber0 force-pushed the new-angular-control-flow branch from 76c8f65 to 419d6a9 Compare September 6, 2024 12:16
Copy link

sonarqubecloud bot commented Sep 6, 2024

@MoritzWeber0 MoritzWeber0 merged commit cfc54db into main Sep 6, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the new-angular-control-flow branch September 6, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants