Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add support for ESLint 9 #1725

Merged
merged 5 commits into from
Sep 3, 2024
Merged

ci: Add support for ESLint 9 #1725

merged 5 commits into from
Sep 3, 2024

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Aug 29, 2024

  • Move import sorting to prettier (Import sorting alg. has changed)
  • Remove unused dependencies
  • Replace .eslintrs.js with eslint.config.mjs
  • Update frontend and pre-commit versions
  • Replace archived prettier mirror with local pre-commit hook
  • Replace deprecation plugin with no-deprecation rule of typescript-eslint
  • Use CommonJS because ESModules doesn't respect the NODE_PATH environment variable.

Resolves #1730

Copy link

github-actions bot commented Aug 29, 2024

A Storybook preview is available for commit 528c537.
View Storybook
View Chromatic build

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.04%. Comparing base (53a8abe) to head (3422a83).
Report is 379 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1725   +/-   ##
=======================================
  Coverage   84.04%   84.04%           
=======================================
  Files         186      186           
  Lines        6135     6135           
  Branches      675      675           
=======================================
  Hits         5156     5156           
  Misses        831      831           
  Partials      148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review September 2, 2024 15:41
@MoritzWeber0 MoritzWeber0 force-pushed the frontend-update branch 6 times, most recently from 5525183 to 901676d Compare September 3, 2024 08:49
- Move import sorting to prettier (Import sorting alg. has changed)
- Remove unused dependencies
- Replace `.eslintrs.js` with `eslint.config.mjs`
- Update frontend and pre-commit versions
- Replace archived prettier mirror with local pre-commit hook
- Replace deprecation plugin with no-deprecation rule of typescript-eslint
The sorting algorithm is slightly different.
Copy link

sonarqubecloud bot commented Sep 3, 2024

@MoritzWeber0 MoritzWeber0 merged commit edb9813 into main Sep 3, 2024
30 checks passed
@MoritzWeber0 MoritzWeber0 deleted the frontend-update branch September 3, 2024 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to ESLint 9
1 participant