feat: Add icons to session indicator for a11y #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Storybook preview is available for commit f056d39. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1712 +/- ##
=======================================
Coverage 84.04% 84.04%
=======================================
Files 186 186
Lines 6135 6135
Branches 675 675
=======================================
Hits 5156 5156
Misses 831 831
Partials 148 148 ☔ View full report in Codecov by Sentry. |
Using color for the session indicator makes it more difficult to read for colorblind people. This PR adds icons which help with quickly identifying the session state. Corresponding stories are also added to showcase the new icons. Closes #1709
MoritzWeber0
force-pushed
the
session-status-icons
branch
from
56b73ac to
39eafa2
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using color for the session indicator makes it more difficult to read for colorblind people.
This PR adds icons which help with quickly identifying the session state. Corresponding stories are also added to showcase the new icons.
Closes #1709