feat: Allow customizing Nav URLs #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A Storybook preview is available for commit 3361717. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1696 +/- ##
==========================================
- Coverage 83.97% 83.70% -0.27%
==========================================
Files 184 186 +2
Lines 6085 6371 +286
Branches 673 729 +56
==========================================
+ Hits 5110 5333 +223
- Misses 827 877 +50
- Partials 148 161 +13 ☔ View full report in Codecov by Sentry. |
MoritzWeber0
requested changes
Aug 12, 2024
frontend/src/app/general/nav-bar-menu/nav-bar-menu.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/general/nav-bar-menu/nav-bar-menu.component.html
Outdated
Show resolved
Hide resolved
zusorio
force-pushed
the
custom-nav-links
branch
3 times, most recently
from
9fa91a9 to
042b476
Compare
MoritzWeber0
requested changes
Aug 15, 2024
|
The Storybook stories have changed since it doesn't recognize external links anymore (since they are defined in the backend). Can we mock it accordingly to preserve the current stories? https://www.chromatic.com/build?appId=6605ea865df51dc81afca5e8&number=359 |
zusorio
force-pushed
the
custom-nav-links
branch
from
d1fb21e to
d94d578
Compare
Allow changing the order and text of the existing nav bar links, as well as add completely custom ones. This can be set in the admin interface by editing the configuration. Closes #1668
zusorio
force-pushed
the
custom-nav-links
branch
from
d94d578 to
dc9d416
Compare
|
MoritzWeber0
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow changing the order and text of the existing nav bar links, as well as add completely custom ones. This can be set in the admin interface by editing the configuration.
chrome_mEZDHqdKC4.mp4