-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Auto-select recommended version for read-only sessions #1683
Conversation
A Storybook preview is available for commit 1212e9c. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1683 +/- ##
=======================================
Coverage 83.97% 83.97%
=======================================
Files 184 184
Lines 6086 6086
Branches 673 673
=======================================
Hits 5111 5111
Misses 827 827
Partials 148 148 ☔ View full report in Codecov by Sentry. |
37f2cb8
to
ef4ef9e
Compare
The pull request does not conform to the conventional commit specification. Please ensure that your commit messages follow the spec: https://www.conventionalcommits.org/. This is the commit validation log:
Here are some examples of valid commit messages:
|
This updates the read-only session creator so that it picks the recommended version, should there be one. Fixes #1354
ef4ef9e
to
d956401
Compare
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, works as expected in my local environment. Thanks for the implementation! 👍
Fixes #1354