refactor!: Restructure SOPS files in Gitlab CI/CD templates #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzWeber0
force-pushed
the
sops-ci-template
branch
from
bf8b027 to
57b9a4e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1680 +/- ##
=======================================
Coverage 83.97% 83.97%
=======================================
Files 184 184
Lines 6086 6086
Branches 673 673
=======================================
Hits 5111 5111
Misses 827 827
Partials 148 148 ☔ View full report in Codecov by Sentry. |
MoritzWeber0
force-pushed
the
sops-ci-template
branch
from
57b9a4e to
c5a5dd2
Compare
- The `unencrypted` suffix was removed from the files. Instead, it's recommended to use the `encrypted_regex` configuration as described in the admin documentation - The `general.values.yaml` and `secret.values.yaml` were merged into one encrypted file `values.yaml`. Also in this case it's recommended to use the `encrypted_regex` configuration. - Decrypt the sops file in-memory and never write them to disk. This improves security.
MoritzWeber0
force-pushed
the
sops-ci-template
branch
from
c5a5dd2 to
c8c0c59
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unencryptedsuffix was removed from the files. Instead, it's recommended to use theencrypted_regexconfiguration as described in the admin documentationgeneral.values.yamlandsecret.values.yamlwere merged into one encrypted filevalues.yaml. Also in this case it's recommended to use theencrypted_regexconfiguration.