Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Reenable deprecation ESLint rule #1330

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

We had to disable the deprecation rule due to many deprecated modules after an Angular update. After replacing all deprecated modules step by step, we can reenable the rule again.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6d256e) 73.22% compared to head (c0a1045) 73.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1330   +/-   ##
=======================================
  Coverage   73.22%   73.22%           
=======================================
  Files         166      166           
  Lines        5431     5431           
  Branches      608      608           
=======================================
  Hits         3977     3977           
  Misses       1323     1323           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

We had to disable the deprecation rule due to many deprecated modules
after an Angular update. After replacing all deprecated modules step by step,
we can reenable the rule again.
@MoritzWeber0 MoritzWeber0 requested review from romeonicholas and removed request for romeonicholas February 13, 2024 10:02
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 40e7984 into main Feb 14, 2024
26 checks passed
@MoritzWeber0 MoritzWeber0 deleted the reenable-deprecation branch February 14, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant