refactor: Use dataclasses for all SQLAlchemy database classes #1328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzWeber0
force-pushed
the
sqlalchemy-dataclass
branch
4 times, most recently
from
c4065cf to
8d48fbf
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
==========================================
- Coverage 73.22% 73.12% -0.11%
==========================================
Files 166 166
Lines 5431 5448 +17
Branches 608 610 +2
==========================================
+ Hits 3977 3984 +7
- Misses 1323 1331 +8
- Partials 131 133 +2 ☔ View full report in Codecov by Sentry. |
With dataclasses, a `__init__` function is created for all database classes. This adds autocomplete and code recommendations and type checkers like mypy can check the passed types. Since the `__hash__` method was removed during this change, the intersection method to get common projects doesn't work anymore. I changed it to a proper database join, which is faster. In addition, many type annotations were added. Some mypy and pylint errors and warnings were fixed in the tests.
MoritzWeber0
force-pushed
the
sqlalchemy-dataclass
branch
from
8d48fbf to
0e4bb45
Compare
|
romeonicholas
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With dataclasses, a
__init__function is created for all database classes. This adds autocomplete and code recommendations and type checkers like mypy can check the passed types.Since the
__hash__method was removed during this change, the intersectionmethod to get common projects doesn't work anymore. I changed it to a proper
database join, which is faster.
In addition, many type annotations were added. Some mypy and pylint errors
and warnings were fixed in the tests.
Resolves #1326