Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Apply prettier layout globally #1323

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

No description provided.

Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Feb 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5065f15) 73.21% compared to head (c4c8d3a) 73.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         166      166           
  Lines        5428     5428           
  Branches      607      607           
=======================================
  Hits         3974     3974           
  Misses       1323     1323           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@romeonicholas romeonicholas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Running this branch locally worked fine, and consistency is always nice. I don't think I see anything that would break in the .yamls and I have to assume prettier would do any necessary escape changes anyway?

@MoritzWeber0
Copy link
Member Author

Running this branch locally worked fine, and consistency is always nice. I don't think I see anything that would break in the .yamls and I have to assume prettier would do any necessary escape changes anyway?

The PR shouldn't contain any breaking changes 👍

@MoritzWeber0 MoritzWeber0 merged commit c27066d into main Feb 7, 2024
26 checks passed
@MoritzWeber0 MoritzWeber0 deleted the prettier-globally branch February 7, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants