Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Optimize some error messages #1321

Merged
merged 1 commit into from
Feb 6, 2024
Merged

Conversation

MoritzWeber0
Copy link
Member

Make them clearer and easier to understand.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d881415) 73.21% compared to head (57d7a66) 73.21%.
Report is 4 commits behind head on main.

❗ Current head 57d7a66 differs from pull request most recent head 6f9bc0e. Consider uploading reports for the commit 6f9bc0e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1321   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         166      166           
  Lines        5428     5428           
  Branches      607      607           
=======================================
  Hits         3974     3974           
  Misses       1323     1323           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 requested review from romeonicholas and removed request for amolenaar February 6, 2024 10:20
Make them clearer and easier to understand.
Copy link

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@MoritzWeber0 MoritzWeber0 merged commit 54ba4a6 into main Feb 6, 2024
24 checks passed
@MoritzWeber0 MoritzWeber0 deleted the optimize-error-msgs branch February 6, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants