Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update licences and instances of DB Netz AG to DB InfraGO AG #1254

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

romeonicholas
Copy link
Contributor

Resolves #1225

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (eb64a9d) 72.85% compared to head (10b4b9a) 72.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1254   +/-   ##
=======================================
  Coverage   72.85%   72.85%           
=======================================
  Files         162      162           
  Lines        5345     5345           
  Branches      601      601           
=======================================
  Hits         3894     3894           
  Misses       1320     1320           
  Partials      131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romeonicholas
Copy link
Contributor Author

Hey @dominik003, it looks like because I'm touching every single file sonarcloud has an issue with existing concerns. I'm not sure I want to resolve those as Won't Fix without someone taking a look first though, if you're able 🐞

@dominik003
Copy link
Contributor

Hey @dominik003, it looks like because I'm touching every single file sonarcloud has an issue with existing concerns. I'm not sure I want to resolve those as Won't Fix without someone taking a look first though, if you're able 🐞

Sure, I'll look over!

In addition, mypy seems to fail in our pre-commit hook with the following error:

Argument 2 to "add_exception_handler" of "Starlette" has incompatible type "Callable[[Request, UserNotFoundError], Coroutine[Any, Any, Response]]"; expected "Callable[[Request, Exception], Response | Awaitable[Response]] | Callable[[WebSocket, Exception], Awaitable[None]]"  [arg-type]

So essentially stating that our type:

Callable[[Request, UserNotFoundError], Coroutine[Any, Any, Response]]

is not one of the following expected one:

Callable[[Request, Exception], Response | Awaitable[Response]] | Callable[[WebSocket, Exception], Awaitable[None]]

However, as far as I can see, the our UserNotFoundError is a sub type of Exception and as stated in the docs, All Coroutine instances are also instances of Awaitable. So together with the fact that this just works fine, I would suggest to simply put # type: ignore[arg-type] to all of those lines.

The only weird thing is that this error just occurred now, so not quite sure what changed for it to occur.

@romeonicholas romeonicholas force-pushed the license-update branch 5 times, most recently from 172b674 to 8d0c6f6 Compare January 2, 2024 12:38
Copy link
Contributor

@dominik003 dominik003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care of the renaming. There is only one link in the README, which we can already change to the new page. After that I can merge it.

README.md Outdated Show resolved Hide resolved
Copy link

sonarqubecloud bot commented Jan 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dominik003 dominik003 merged commit 1bc5a44 into main Jan 2, 2024
25 checks passed
@dominik003 dominik003 deleted the license-update branch January 2, 2024 13:54
@MoritzWeber0
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace license headers with new entity
3 participants