Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Properly set API url when editing Git instance settings #1234

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: Properly set API url when editing Git instance settings #1234

merged 1 commit into from
Dec 12, 2023

Conversation

dominik003
Copy link
Contributor

@dominik003 dominik003 commented Dec 12, 2023 •
edited
Loading

Resolves #1233

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MoritzWeber0 MoritzWeber0 changed the title fix: Properly set api url when editing git setting fix: Properly set API url when editing Git settings Dec 12, 2023
@MoritzWeber0 MoritzWeber0 changed the title fix: Properly set API url when editing Git settings fix: Properly set API url when editing Git instance settings Dec 12, 2023
@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f6e8fb9) 72.69% compared to head (dcbd760) 72.69%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   72.69%   72.69%           
=======================================
  Files         162      162           
  Lines        5315     5315           
  Branches      597      597           
=======================================
  Hits         3864     3864           
  Misses       1320     1320           
  Partials      131      131

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 merged commit d3f7b10 into main Dec 12, 2023
25 checks passed
@MoritzWeber0 MoritzWeber0 deleted the fix-git-setting-issues branch December 12, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto fill for editing of git settings does not properly work
2 participants
@dominik003 @MoritzWeber0