Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: No longer require -j4 in make dev #1169

Merged
merged 1 commit into from
Nov 13, 2023
Merged

build: No longer require -j4 in make dev #1169

merged 1 commit into from
Nov 13, 2023

Conversation

MoritzWeber0
Copy link
Member

Developers can simply run make dev instead of make -j4 dev. Since the target does only work with parallel execution endabled, the parallel execution is now the default.

Developers can simply run `make dev` instead of `make -j4 dev`.
Since the target does only work with parallel execution endabled,
the parallel execution is now the default.
Copy link

sonarqubecloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7af54dd) 72.50% compared to head (97e6db6) 72.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1169   +/-   ##
=======================================
  Coverage   72.50%   72.50%           
=======================================
  Files         162      162           
  Lines        5289     5289           
  Branches      592      592           
=======================================
  Hits         3835     3835           
  Misses       1322     1322           
  Partials      132      132           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@amolenaar amolenaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Simple and elegant.

@MoritzWeber0 MoritzWeber0 merged commit 570e9a1 into main Nov 13, 2023
25 checks passed
@MoritzWeber0 MoritzWeber0 deleted the make-dev branch November 13, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants