Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Prohibit use of print function #1151

Merged
merged 1 commit into from
Nov 1, 2023
Merged

ci: Prohibit use of print function #1151

merged 1 commit into from
Nov 1, 2023

Conversation

MoritzWeber0
Copy link
Member

There were again a few print statements, which messed up the logs.
We should use log messages instead of print statements. If a print statement is required, disable the pylint warning.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (61a7b06) 72.09% compared to head (b66672e) 72.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1151      +/-   ##
==========================================
- Coverage   72.09%   72.08%   -0.02%     
==========================================
  Files         160      160              
  Lines        5129     5126       -3     
  Branches      555      555              
==========================================
- Hits         3698     3695       -3     
  Misses       1322     1322              
  Partials      109      109              
Files Coverage Δ
backend/capellacollab/config/diff.py 0.00% <ø> (ø)
backend/capellacollab/projects/routes.py 83.33% <ø> (-0.46%) ⬇️
...ects/toolmodels/modelsources/git/github/handler.py 84.61% <ø> (-0.20%) ⬇️
...capellacollab/settings/modelsources/git/askpass.py 0.00% <0.00%> (ø)
backend/capellacollab/sessions/operators/k8s.py 36.08% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MoritzWeber0 MoritzWeber0 merged commit b51e6dc into main Nov 1, 2023
24 of 25 checks passed
@MoritzWeber0 MoritzWeber0 deleted the prohibit-print branch November 1, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants