feat: Add tiling window manager for training mode #1150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1150 +/- ##
=======================================
Coverage 72.50% 72.50%
=======================================
Files 162 162
Lines 5289 5289
Branches 592 592
=======================================
Hits 3835 3835
Misses 1322 1322
Partials 132 132 ☔ View full report in Codecov by Sentry. |
dominik003
force-pushed
the
feat-training-mode-session-viewer
branch
3 times, most recently
from
a4f52c2 to
05c7bca
Compare
dominik003
changed the title
dominik003
force-pushed
the
feat-training-mode-session-viewer
branch
4 times, most recently
from
a0e895a to
75792e7
Compare
MoritzWeber0
reviewed
Nov 3, 2023
...tend/src/app/sessions/session/floating-window-manager/floating-window-manager.component.html
Show resolved
Hide resolved
frontend/src/app/sessions/session/tiling-window-manager/tiling-window-manager.component.ts
Show resolved
Hide resolved
frontend/src/app/sessions/session/tiling-window-manager/tiling-window-manager.component.ts
Show resolved
Hide resolved
...tend/src/app/sessions/session/floating-window-manager/floating-window-manager.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/session/tiling-window-manager/tiling-window-manager.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/session/tiling-window-manager/tiling-window-manager.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/session/tiling-window-manager/tiling-window-manager.component.ts
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/session/tiling-window-manager/tiling-window-manager.component.html
Outdated
Show resolved
Hide resolved
frontend/src/app/sessions/session/tiling-window-manager/tiling-window-manager.component.html
Outdated
Show resolved
Hide resolved
dominik003
force-pushed
the
feat-training-mode-session-viewer
branch
from
75792e7 to
3e18712
Compare
dominik003
force-pushed
the
feat-training-mode-session-viewer
branch
from
3e18712 to
d05fc5a
Compare
dominik003
force-pushed
the
feat-training-mode-session-viewer
branch
from
d05fc5a to
5f644ad
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MoritzWeber0
approved these changes
Nov 27, 2023
|
I noticed in our staging environment that there is still a small bug: iFrame events are not disabled while moving the session. This leads to a buggy behaviour when the user moved the session to fast and moves the cursor in the actual iframe. |
MoritzWeber0
added a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes a bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This leds to a "jumpy" behaviour while resizing.
MoritzWeber0
added a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This leds to a "jumpy" behaviour while resizing.
MoritzWeber0
added a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This led to a "jumpy" behaviour while resizing.
MoritzWeber0
added a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This led to a "jumpy" behaviour while resizing.
romeonicholas
pushed a commit
that referenced
this pull request
Nov 28, 2023
This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This led to a "jumpy" behaviour while resizing.
romeonicholas
added a commit
that referenced
this pull request
Dec 12, 2023
fix: Get reorder path working fix: Bad merge fix: Hide reorder button from non-managers refactor: remove unused comments style: Clean up reorder modal feat: Add function to update a group of models, use for model reordering fix: Remove unused imports feat: order models by id when no display order has been set docs: Add missing license headers fix: Remove excess declaration and format files fix: Rename angular functions to meet linter standards fix: eslint styling fix: Move display order out of post model test: Add test to patch model display order fix: Revert unecessary angular function name changes This reverts commit e876fed. build: Update frontend versions build(deps-dev): bump alembic from 1.12.0 to 1.12.1 in /backend Bumps [alembic](https://github.com/sqlalchemy/alembic) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/sqlalchemy/alembic/releases) - [Changelog](https://github.com/sqlalchemy/alembic/blob/main/CHANGES) - [Commits](https://github.com/sqlalchemy/alembic/commits) --- updated-dependencies: - dependency-name: alembic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> docs(user): Add instructions for secondary click on macOS The usual option to press `Control` while clicking doesn't work in RDP-sessions on macOS. The `Control` can't be evaluated and mapped properly. It's passed to the Linux container, which can't handle the `Control` key. refactor: Create floating window mgr component feat: Add tiling window manager with slider build: Update frontend versions fix(session-viewer): Disable pointer event while resizing sessions This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This led to a "jumpy" behaviour while resizing. fix: Get reorder path working fix: Undo rebase errors feat: Add tiling window manager with slider fix: Get reorder path working Revert "build: Update frontend versions" This reverts commit 800f6ce. build: Update frontend versions build(deps-dev): bump alembic from 1.12.0 to 1.12.1 in /backend Bumps [alembic](https://github.com/sqlalchemy/alembic) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/sqlalchemy/alembic/releases) - [Changelog](https://github.com/sqlalchemy/alembic/blob/main/CHANGES) - [Commits](https://github.com/sqlalchemy/alembic/commits) --- updated-dependencies: - dependency-name: alembic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> docs(user): Add instructions for secondary click on macOS The usual option to press `Control` while clicking doesn't work in RDP-sessions on macOS. The `Control` can't be evaluated and mapped properly. It's passed to the Linux container, which can't handle the `Control` key. refactor: Create floating window mgr component feat: Add tiling window manager with slider build: Update frontend versions fix(session-viewer): Disable pointer event while resizing sessions This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This led to a "jumpy" behaviour while resizing. fix: Migrate logic for button showing to Angular 17 blocks fix: replace if statement with rxjs filtering fix: Remove unused matdialog declaration fix: Shift logic for project check to come before sending data fix: Refactor data model for reordering view fix: Rename all related instances of reorderModels to reorderModelsDialog fix: Update for loop of models to Angular 17 format fix: Separate out patchModel to reduce duplication in model updates fix: Manually format html fix: use model ids in place of names and rename patch function
romeonicholas
added a commit
that referenced
this pull request
Dec 12, 2023
feat: update models table and functions for display order fix: Get reorder path working fix: Bad merge fix: Hide reorder button from non-managers refactor: remove unused comments style: Clean up reorder modal feat: Add function to update a group of models, use for model reordering fix: Remove unused imports feat: order models by id when no display order has been set docs: Add missing license headers fix: Remove excess declaration and format files fix: Rename angular functions to meet linter standards fix: eslint styling fix: Move display order out of post model test: Add test to patch model display order fix: Revert unecessary angular function name changes This reverts commit e876fed. build: Update frontend versions build(deps-dev): bump alembic from 1.12.0 to 1.12.1 in /backend Bumps [alembic](https://github.com/sqlalchemy/alembic) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/sqlalchemy/alembic/releases) - [Changelog](https://github.com/sqlalchemy/alembic/blob/main/CHANGES) - [Commits](https://github.com/sqlalchemy/alembic/commits) --- updated-dependencies: - dependency-name: alembic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> docs(user): Add instructions for secondary click on macOS The usual option to press `Control` while clicking doesn't work in RDP-sessions on macOS. The `Control` can't be evaluated and mapped properly. It's passed to the Linux container, which can't handle the `Control` key. refactor: Create floating window mgr component feat: Add tiling window manager with slider build: Update frontend versions fix(session-viewer): Disable pointer event while resizing sessions This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This led to a "jumpy" behaviour while resizing. fix: Get reorder path working fix: Undo rebase errors feat: Add tiling window manager with slider fix: Get reorder path working Revert "build: Update frontend versions" This reverts commit 800f6ce. build: Update frontend versions build(deps-dev): bump alembic from 1.12.0 to 1.12.1 in /backend Bumps [alembic](https://github.com/sqlalchemy/alembic) from 1.12.0 to 1.12.1. - [Release notes](https://github.com/sqlalchemy/alembic/releases) - [Changelog](https://github.com/sqlalchemy/alembic/blob/main/CHANGES) - [Commits](https://github.com/sqlalchemy/alembic/commits) --- updated-dependencies: - dependency-name: alembic dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> docs(user): Add instructions for secondary click on macOS The usual option to press `Control` while clicking doesn't work in RDP-sessions on macOS. The `Control` can't be evaluated and mapped properly. It's passed to the Linux container, which can't handle the `Control` key. refactor: Create floating window mgr component feat: Add tiling window manager with slider build: Update frontend versions fix(session-viewer): Disable pointer event while resizing sessions This commit fixes a small bug that was introduced in #1150. When the pointer events are not disabled on the iframe, some pointer events are "stolen" by the iframe. Therefore, they can not be used by our event handlers. This led to a "jumpy" behaviour while resizing. fix: Migrate logic for button showing to Angular 17 blocks fix: replace if statement with rxjs filtering fix: Remove unused matdialog declaration fix: Shift logic for project check to come before sending data fix: Refactor data model for reordering view fix: Rename all related instances of reorderModels to reorderModelsDialog fix: Update for loop of models to Angular 17 format fix: Separate out patchModel to reduce duplication in model updates fix: Manually format html fix: use model ids in place of names and rename patch function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #990, Resolves #982, Resolves #985
Things still needed before merge: