feat: Show code snipped in diagram cache dialog #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1147 +/- ##
==========================================
+ Coverage 72.69% 72.72% +0.02%
==========================================
Files 162 162
Lines 5315 5320 +5
Branches 597 597
==========================================
+ Hits 3864 3869 +5
Misses 1320 1320
Partials 131 131 ☔ View full report in Codecov by Sentry. |
Paula-Kli
force-pushed
the
show-codesnippet
branch
from
302a414 to
3da5b3a
Compare
|
Currently looks like I used CSS in order to style it as I thought would be nicer than javascript - nevertheless the copied code still has a lot of white spaces in front even though they do not get displayed... |
Paula-Kli
force-pushed
the
show-codesnippet
branch
from
3da5b3a to
8c3503e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
MoritzWeber0
requested changes
Oct 31, 2023
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
Outdated
Show resolved
Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
Outdated
Show resolved
Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
Outdated
Show resolved
Hide resolved
Paula-Kli
force-pushed
the
show-codesnippet
branch
from
8c3503e to
56c7855
Compare
In order for users to better understand how a personal access token can be helpful the codesnippet from the docs is displayed in the frontend.
MoritzWeber0
force-pushed
the
show-codesnippet
branch
2 times, most recently
from
c3d3fb2 to
4d390cf
Compare
dominik003
approved these changes
Dec 14, 2023
...agrams/model-diagram-dialog/model-diagram-code-block/model-diagram-code-block.component.html
Outdated
Show resolved
Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
Outdated
Show resolved
Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
Outdated
Show resolved
Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
Outdated
Show resolved
Hide resolved
...nd/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.html
Outdated
Show resolved
Hide resolved
...tend/src/app/projects/models/diagrams/model-diagram-dialog/model-diagram-dialog.component.ts
Outdated
Show resolved
Hide resolved
MoritzWeber0
force-pushed
the
show-codesnippet
branch
3 times, most recently
from
88943d3 to
24bdf70
Compare
The commits identifies the primary Git model of a model and adds the information to the code snippet of the diagram cache. In addition, there were some minor/internal changes: - The code snippet code was moved to a new component `ModelDiagramCacheBlockComponent`. - Syntax highlighting was added in the frontend. - A duplication of the code snippet declaration was removed. - Margins and paddings were updated, responsive design was added. - The colors of the code snippet were inverted (white text on dark background) - Information about token revocation was added to the dialog. - A confirmation message for clipboard-copy was added.
MoritzWeber0
force-pushed
the
show-codesnippet
branch
from
24bdf70 to
f45fba3
Compare
MoritzWeber0
approved these changes
Dec 15, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order for users to better understand how a personal access token can be helpful the codesnippet from the docs is displayed in the frontend.
closes #598