Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Let Git ignore dirty capella-dockerimages submodule #1106

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Oct 18, 2023

Git submodules are often staged and committed accidentally. We are generally not supposed to commit dirty submodules, so we can let Git ignore them. Dirty submodules are no longer shown as modified in git status.

Git submodules are often staged and committed accidentally.
We are generally not supposed to commit dirty submodules,
so we can let Git ignore them. Dirty submodules are no
longer shown as modified in git status.
@MoritzWeber0 MoritzWeber0 force-pushed the ignore-dirty-submodule branch from b93b14e to b72788b Compare October 18, 2023 10:31
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (685f7ca) 71.61% compared to head (b72788b) 71.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   71.61%   71.61%           
=======================================
  Files         160      160           
  Lines        5073     5073           
  Branches      543      543           
=======================================
  Hits         3633     3633           
  Misses       1336     1336           
  Partials      104      104           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Paula-Kli Paula-Kli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@MoritzWeber0 MoritzWeber0 merged commit bad31a0 into main Oct 20, 2023
23 checks passed
@MoritzWeber0 MoritzWeber0 deleted the ignore-dirty-submodule branch October 20, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants