fix: Ensure that PostgreSQL database uses 'UTC' timezone #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application stores the datatime objects in a timezone naive format. Therefore, we store them as UTC and also expect to get UTC as response. We expect the database to run in UTC, it should not perform any additional datetime or timezone transformation. The transformation is done in the application. However, some databases run in different timezones. In this case, we ensure that UTC is used for our transactions.
MoritzWeber0
changed the title
dominik003
approved these changes
Oct 16, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1098 +/- ##
=======================================
Coverage 71.61% 71.61%
=======================================
Files 160 160
Lines 5073 5073
Branches 543 543
=======================================
Hits 3633 3633
Misses 1336 1336
Partials 104 104
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The application stores the datatime objects in a timezone naive format. Therefore, we store them as UTC and also expect to get UTC as response.
We expect the database to run in UTC, it should not perform any additional datetime or timezone transformation. The transformation is done in the application.
However, some databases run in different timezones. In this case, we ensure that UTC is used for our transactions.