fix: Remove file ending in diagram route #1090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1090 +/- ##
==========================================
+ Coverage 71.61% 71.64% +0.02%
==========================================
Files 160 160
Lines 5073 5078 +5
Branches 543 544 +1
==========================================
+ Hits 3633 3638 +5
Misses 1336 1336
Partials 104 104
☔ View full report in Codecov by Sentry. |
Paula-Kli
force-pushed
the
diagram_cache_file_ending
branch
from
0fae1be to
06a3fc4
Compare
Paula-Kli
force-pushed
the
diagram_cache_file_ending
branch
from
06a3fc4 to
ab4b4a4
Compare
Paula-Kli
force-pushed
the
diagram_cache_file_ending
branch
from
ab4b4a4 to
e723066
Compare
MoritzWeber0
requested changes
Oct 13, 2023
Paula-Kli
force-pushed
the
diagram_cache_file_ending
branch
2 times, most recently
from
63a96e7 to
3ccb8b9
Compare
Paula-Kli
force-pushed
the
diagram_cache_file_ending
branch
from
3ccb8b9 to
c0c8bd7
Compare
Paula-Kli
force-pushed
the
diagram_cache_file_ending
branch
from
c0c8bd7 to
138847a
Compare
MoritzWeber0
approved these changes
Oct 20, 2023
When using the diagram cache the route should not run into errors when calling diagrams with a file ending or without.
Paula-Kli
force-pushed
the
diagram_cache_file_ending
branch
from
138847a to
b6bc98d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the diagram cache the route should not run into errors when calling diagrams with a file ending or without.