-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Add ESLint and prettier tailwind plugins #1085
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage 71.55% 71.55%
=======================================
Files 160 160
Lines 5076 5076
Branches 543 543
=======================================
Hits 3632 3632
Misses 1341 1341
Partials 103 103 ☔ View full report in Codecov by Sentry. |
cdc4519
to
6a60aeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am curious: do you know why the tailwind class names order is switched in many cases even though you turned that off in the config?
It's turned off because prettier takes care of it. There is no need to run it twice (in ESLint and Prettier). That's why I turned it off in ESLint. |
6a60aeb
to
12a7ecc
Compare
It enforces a unique classname order and prevents contradicting classnames. All supported rules are described here: https://www.npmjs.com/package/eslint-plugin-tailwindcss
The plugin auto-sorts the used classes.
12a7ecc
to
f6c5563
Compare
It enforces a unique classname order and prevents contradicting classnames. All supported rules are described here: https://www.npmjs.com/package/eslint-plugin-tailwindcss
You just have to review four commits, you can skip the 6358e34 commit. In this commit, only the result
pre-commit run -a
was committed.