feat: Improve diagram cache margins on mobile phones #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diagram overview and diagram viewer makes now full use of the available space on mobile phones. As the previous way to close the diagram by just pressing next to it it not available anymore (there are no margins), there is a new sticky close button on mobile phones. The UI on devices with wider screens (>=1024px) doesn't change.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1032 +/- ##
=======================================
Coverage 71.14% 71.14%
=======================================
Files 154 154
Lines 4820 4820
Branches 513 513
=======================================
Hits 3429 3429
Misses 1294 1294
Partials 97 97 ☔ View full report in Codecov by Sentry. |
MoritzWeber0
requested review from
dominik003
and removed request for
dominik003
dominik003
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diagram overview and diagram viewer makes now full use of the available space on mobile phones.
As the previous way to close the diagram by just pressing next to it it not available anymore (there are no margins),
there is a new sticky close button on mobile phones.
The UI on devices with wider screens (>=1024px) doesn't change.
Thanks to @vik378 for proposing this improvement.
A screenshot of the new UI (grey area is outside of the device screen):