Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move non-critical session containers to external Pod #1980

Closed
MoritzWeber0 opened this issue Nov 12, 2024 · 0 comments · Fixed by #1982
Closed

Move non-critical session containers to external Pod #1980

MoritzWeber0 opened this issue Nov 12, 2024 · 0 comments · Fixed by #1982

Comments

@MoritzWeber0
Copy link
Member

In #1971, we changed the restart policy to never. This makes sense to properly handle and investigate session crashed.

Unfortunately, after the change, a session gets unhealthy when an non-critical sidecar container like promtail crashes (e.g. due to OOM). It's currently not possible to set an individual restart policy on containers.

Instead, we should spawn a separate Pod for promtail.
@MoritzWeber0 MoritzWeber0 moved this from Backlog to Ready for Review in Capella Collaboration Roadmap 🚀 Nov 12, 2024
@MoritzWeber0 MoritzWeber0 moved this from Ready for Review to Planned in Capella Collaboration Roadmap 🚀 Nov 12, 2024
MoritzWeber0 added a commit that referenced this issue Nov 12, 2024
@MoritzWeber0
fix: Move promtail container to external Pod
52969d4 
Resolves #1980
@MoritzWeber0 MoritzWeber0 mentioned this issue Nov 12, 2024
Merged
MoritzWeber0 added a commit that referenced this issue Nov 12, 2024
@MoritzWeber0
fix: Move promtail container to external Pod
2439eaf 
Resolves #1980
MoritzWeber0 added a commit that referenced this issue Nov 12, 2024
@MoritzWeber0
fix: Move promtail container to external Pod
c894534 
Resolves #1980
MoritzWeber0 added a commit that referenced this issue Nov 12, 2024
@MoritzWeber0
fix: Move promtail container to external Pod
275b1be 
Resolves #1980
@MoritzWeber0 MoritzWeber0 moved this from Planned to Done in Capella Collaboration Roadmap 🚀 Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Capella Collaboration Roadmap 🚀
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Move promtail container to external Pod DSD-DBS/capella-collab-manager
1 participant
@MoritzWeber0