fix: Separate out patchModel to reduce duplication in model updates

DSD-DBS · Nov 29, 2023 · d26dd6f · d26dd6f
1 parent f452815
commit d26dd6f
Showing 1 changed file with 20 additions and 17 deletions.
diff --git a/frontend/src/app/projects/models/service/model.service.ts b/frontend/src/app/projects/models/service/model.service.ts
@@ -92,35 +92,38 @@ export class ModelService {
       );
   }
 
+  private patchModel(
+    projectSlug: string,
+    modelSlug: string,
+    patchData: PatchModel,
+  ): Observable<Model> {
+    return this.http.patch<Model>(
+      `${this.base_url}${projectSlug}/models/${modelSlug}/`,
+      patchData,
+    );
+  }
+
   updateModel(
     projectSlug: string,
     modelSlug: string,
     patchModel: PatchModel,
   ): Observable<Model> {
-    return this.http
-      .patch<Model>(
-        `${this.base_url}${projectSlug}/models/${modelSlug}/`,
-        patchModel,
-      )
-      .pipe(
-        tap({
-          next: (model) => {
-            this.loadModels(projectSlug);
-            this._model.next(model);
-          },
-        }),
-      );
+    return this.patchModel(projectSlug, modelSlug, patchModel).pipe(
+      tap({
+        next: (model) => {
+          this.loadModels(projectSlug);
+          this._model.next(model);
+        },
+      }),
+    );
   }
 
   updateModels(
     projectSlug: string,
     modelUpdates: { modelSlug: string; patchModel: PatchModel }[],
   ): Observable<Model[]> {
     const updateObservables = modelUpdates.map(({ modelSlug, patchModel }) =>
-      this.http.patch<Model>(
-        `${this.base_url}${projectSlug}/models/${modelSlug}/`,
-        patchModel,
-      ),
+      this.patchModel(projectSlug, modelSlug, patchModel),
     );
 
     return forkJoin(updateObservables).pipe(